Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

You're over-thinking it. Large PRs have a known effect of reviewers' eyes just glaze over and the PR just gets a cursory glance and LGTM :+1: on it.

That's when you know a PR is "large."

What's stopping you breaking such a PR into smaller chunks? Some arbitrary "it does what it's supposed to do" definition?



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: